Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix TestTaskError and TestMultiError flaky tests (#2779) #2820

Merged
merged 7 commits into from
Sep 22, 2021
Merged

test: fix TestTaskError and TestMultiError flaky tests (#2779) #2820

merged 7 commits into from
Sep 22, 2021

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #2779

What problem does this PR solve?

close https://github.com/pingcap/ticdc/issues/2469

What is changed and how it works?

In one case, it did happen that isCancelled was used to the next event before it was updated, and ErrCh immediately received an error, just as cancel was called during the execution of AddEvent, which is why I encountered this unstable test. I was able to reproduce the problem occasionally after increasing the number of events and limiting resources locally.

Check List

Tests

  • Unit test

Code changes

None

Side effects

None

Related changes

  • Need to cherry-pick to the release branch

Release note 

None

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels Sep 14, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 14, 2021
Merged
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.2 This PR is cherry-picked to release-5.2 from a source PR. labels Sep 14, 2021
@nongfushanquan nongfushanquan added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Sep 18, 2021
@amyangfei amyangfei added this to the v5.2.2 milestone Sep 18, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: fb8ab04

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 18, 2021
@amyangfei
Copy link
Contributor

/run-integration-tests

@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release-5.2@7614898). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-5.2      #2820   +/-   ##
================================================
  Coverage               ?   56.2207%           
================================================
  Files                  ?        169           
  Lines                  ?      20713           
  Branches               ?          0           
================================================
  Hits                   ?      11645           
  Misses                 ?       7941           
  Partials               ?       1127

@ti-chi-bot ti-chi-bot merged commit 9a11359 into pingcap:release-5.2 Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rustin170506 Rustin170506 Awaiting requested review from Rustin170506

@overvenus overvenus Awaiting requested review from overvenus

Assignees

@Rustin170506 Rustin170506

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.2 This PR is cherry-picked to release-5.2 from a source PR.
Projects
None yet
Milestone
v5.2.2
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-chi-bot @amyangfei @codecov-commenter @Rustin170506 @nongfushanquan